In calcfrac.c, routine StandardFractal, the HEAD has this comparison: line 2212: if (cmp_bf(abs_a_bf(sub_bf(bftmp,bfsaved.x,bfnew.x)), bfclosenuff) < 0) if (cmp_bf(abs_a_bf(sub_bf(bftmp,bfsaved.y,bfnew.y)), bfclosenuff) < 0) caught_a_cycle = 1; notice that its two calls to cmp_bf(..., ...). In the float-only version, the same code has this comparison: if (cmp_bf(abs_a_bf(sub_bf(bftmp,bfsaved.x,bfnew.x)), bfclosenuff) < 0) if (cmp_bn(abs_a_bf(sub_bf(bftmp,bfsaved.y,bfnew.y)), bfclosenuff) < 0) caught_a_cycle = 1; With one call to cmp_bf and one to cmp_bn. Does anyone remember fixing this bug? The first one looks correct to me. -- "The Direct3D Graphics Pipeline" -- DirectX 9 draft available for download <http://www.xmission.com/~legalize/book/download/index.html> Legalize Adulthood! <http://blogs.xmission.com/legalize/>
Rich asked:
With one call to cmp_bf and one to cmp_bn.
Does anyone remember fixing this bug?
Either Jonathan or me, but not sure if either of us remembers <grin!> Actually I think that fix was fairly recent, so it's probably in CVS The floatonly code is out of date.
The first one looks correct to me.
Yup. Should be all bf calls. Tim
In article <457B26CC.9060.22DE7CA@twegner.swbell.net>, "Tim Wegner" <twegner@swbell.net> writes:
The floatonly code is out of date.
Its not too bad. There are only a few places where it seems to be lagging the HEAD. Most of the differences are "obvious" and a check can be made by looking at the history in the HEAD, but this one made me wonder. I know from lots of years of using CVS that the log messages aren't always specific enough to tell you about a specific line changing. I'll use a single general checkin message to cover lots of files changing. -- "The Direct3D Graphics Pipeline" -- DirectX 9 draft available for download <http://www.xmission.com/~legalize/book/download/index.html> Legalize Adulthood! <http://blogs.xmission.com/legalize/>
Rich,
The floatonly code is out of date.
Its not too bad. There are only a few places where it seems to be lagging the HEAD. Most of the differences are "obvious" and a check can be made by looking at the history in the HEAD, but this one made me wonder. I know from lots of years of using CVS that the log messages aren't always specific enough to tell you about a specific line changing. I'll use a single general checkin message to cover lots of files changing.
For small changes, like this one, I prefer to do a commit immediately with just the one change. That way there is a trail if it is ever needed. For bigger changes, like moving the history routines to a separate source file, I'll commit all the changes after I get it working. I don't have it working in WinFract yet and will commit the changes once it is. Jonathan
I've sort of been following the work you are doing. Great job!
lagging the HEAD. Most of the differences are "obvious" and a check can be made by looking at the history in the HEAD,
What does the term 'HEAD' refer to that you use from time to time? <--<< What IDE, compiler and op sys target are you using for the work you are currently doing? <--<< - Hal Lane ######################### # hallane@earthlink.net <mailto:hallane@earthlink.net> # #########################
-----Original Message----- From: fractdev-bounces+hallane=earthlink.net@mailman.xmission.com [mailto:fractdev-bounces+hallane=earthlink.net@mailman.xmission.com]On Behalf Of Richard Sent: Sunday, December 10, 2006 12:18 AM To: Fractint developer's list Subject: Re: [Fractdev] cmp_bf vs. cmp_bn?
In article <457B26CC.9060.22DE7CA@twegner.swbell.net>, "Tim Wegner" <twegner@swbell.net> writes:
The floatonly code is out of date.
Its not too bad. There are only a few places where it seems to be lagging the HEAD. Most of the differences are "obvious" and a check can be made by looking at the history in the HEAD, but this one made me wonder. I know from lots of years of using CVS that the log messages aren't always specific enough to tell you about a specific line changing. I'll use a single general checkin message to cover lots of files changing. --
-- No virus found in this outgoing message. Checked by AVG Free Edition. Version: 7.1.409 / Virus Database: 268.15.15/581 - Release Date: 12/9/06
In article <MDBBJLBFBICIIEIHFBMEIEKOCOAA.hallane@earthlink.net>, "Hal Lane" <hallane@earthlink.net> writes:
lagging the HEAD. Most of the differences are "obvious" and a check can be made by looking at the history in the HEAD,
What does the term 'HEAD' refer to that you use from time to time? <--<<
In a source code control system (we're using CVS), you can have multiple versions of a document. The different versions are arranged into a tree and the version number identifies the path you take down the tree to get to any particular revision. The tree has a main trunk and branches. The main trunk is referred to as the 'HEAD' and is the revision of the document you get by default from CVS. To get a revision on the branch, you have to request a branch name to be used to get the revision and then you get the latest revision of the document on that branch, sometimes called the 'tip' of the branch. You can specify a particular revision number to get any revision of the document anywhere in its version history. For a big change like I'm doing, its best to work in a branch. Other people can continue to work in the main trunk, or HEAD. (The CVS symbolic name for the main trunk is 'HEAD', which is why I've been using that term in that particular casing.) My changes are broad and somewhat dangerous. Its best not to do this on the HEAD because other people have their changes they are working on in the HEAD and the scope of my changes will just cause them a lot of grief. Particularly since my changes will evolve over time to make everything work and won't be a fully working system for some time. So Jonathan and Tim can work in the HEAD, unimpacted by my changes on the branch. The HEAD is the current development version, 20.04.4. My branch starts at 20.04.4 and diverges to make some fairly wide changes: the introduction of a driver abstraction and a transition to a flat 32-bit memory model.
What IDE, compiler and op sys target are you using for the work you are currently doing? <--<<
I'm using Microsoft Visual Studio .NET 2003 under Windows XP. The target OS is Windows 2000 or later, although it would probably work on Win95 and Win98. God help anyone still using Windows ME :-). The roadmap for the branch is: - Win32 disk driver working - Win32 GDI driver working - X11 driver working - change to float-only - merge into HEAD That is to say that before being merged into the HEAD and created as an official release, it should do everything that the HEAD does now. As each driver gets to where I think its working, I'll create an install package so that other people can test it out and report bugs. -- "The Direct3D Graphics Pipeline" -- DirectX 9 draft available for download <http://www.xmission.com/~legalize/book/download/index.html> Legalize Adulthood! <http://blogs.xmission.com/legalize/>
Richard, Thanks for the clear description of the term 'HEAD'. I once used a version control system on a VAX but I did not know if the paradigms were the same in CVS or what the specific terms were for features in CVS. Thanks again...
The HEAD is the current development version, 20.04.4.
So that means that the Cross Reference you published at: <http://www.xmission.com/~legalize/fractals/fractint-xref/> is for that version, right? <---<< I grabbed a copy of the Cross Reference so if anyone ever needs a copy in the future, I have it here (sort of as a backup -- and to help my understanding of Fractint code.) Also, thanks for describing the differences between:
...the Visual C++ 2005 Express Edition ... [and] ...the VS.NET 2003 academic.
- Hal Lane ######################### # hallane@earthlink.net <mailto:hallane@earthlink.net> # #########################
-----Original Message----- From: fractdev-bounces+hallane=earthlink.net@mailman.xmission.com [mailto:fractdev-bounces+hallane=earthlink.net@mailman.xmission.com]On Behalf Of Richard Sent: Sunday, December 10, 2006 5:53 PM To: Fractint developer's list Subject: Re: [Fractdev] RE: [Richard] What does the term 'HEAD' refer to?;build environment?
"Hal Lane" <hallane@earthlink.net> writes:
lagging the HEAD. Most of the differences are "obvious" and a check can be made by looking at the history in the HEAD,
What does the term 'HEAD' refer to that you use from time to time? <--<<
In a source code control system (we're using CVS), you can have multiple versions of a document. The different versions are arranged into a tree and the version number identifies the path you take down the tree to get to any particular revision.
The tree has a main trunk and branches. The main trunk is referred to as the 'HEAD' and is the revision of the document you get by default from CVS. To get a revision on the branch, you have to request a branch name to be used to get the revision and then you get the latest revision of the document on that branch, sometimes called the 'tip' of the branch. You can specify a particular revision number to get any revision of the document anywhere in its version history.
For a big change like I'm doing, its best to work in a branch. Other people can continue to work in the main trunk, or HEAD. (The CVS symbolic name for the main trunk is 'HEAD', which is why I've been using that term in that particular casing.)
My changes are broad and somewhat dangerous. Its best not to do this on the HEAD because other people have their changes they are working on in the HEAD and the scope of my changes will just cause them a lot of grief. Particularly since my changes will evolve over time to make everything work and won't be a fully working system for some time.
So Jonathan and Tim can work in the HEAD, unimpacted by my changes on the branch. The HEAD is the current development version, 20.04.4. My branch starts at 20.04.4 and diverges to make some fairly wide changes: the introduction of a driver abstraction and a transition to a flat 32-bit memory model.
What IDE, compiler and op sys target are you using for the work you are currently doing? <--<<
I'm using Microsoft Visual Studio .NET 2003 under Windows XP. The target OS is Windows 2000 or later, although it would probably work on Win95 and Win98. God help anyone still using Windows ME :-).
The roadmap for the branch is:
- Win32 disk driver working - Win32 GDI driver working - X11 driver working - change to float-only - merge into HEAD
That is to say that before being merged into the HEAD and created as an official release, it should do everything that the HEAD does now.
As each driver gets to where I think its working, I'll create an install package so that other people can test it out and report bugs. --
-- No virus found in this outgoing message. Checked by AVG Free Edition. Version: 7.1.409 / Virus Database: 268.15.15/581 - Release Date: 12/9/06
In article <MDBBJLBFBICIIEIHFBMEOELCCOAA.hallane@earthlink.net>, "Hal Lane" <hallane@earthlink.net> writes:
The HEAD is the current development version, 20.04.4.
So that means that the Cross Reference you published at: <http://www.xmission.com/~legalize/fractals/fractint-xref/> is for that version, right? <---<<
Yes. -- "The Direct3D Graphics Pipeline" -- DirectX 9 draft available for download <http://www.xmission.com/~legalize/book/download/index.html> Legalize Adulthood! <http://blogs.xmission.com/legalize/>
participants (4)
-
Hal Lane -
Jonathan Osuch -
Richard -
Tim Wegner