Patches for QA issues for compiling xfractint on Gentoo linux
Jonathan, Here are 3 patches that we can apply on Gentoo linux in order to either compile with our musl profile[1] or comply with Gentoo QA. Two of these issues were discovered after your patch 15 and are not related to the previous issue with gcc-10. It seems that the patch about ldflags was around since patch 09. I'm sorry for not telling about this one at the time. Please let me know if you intend to do something about these. Otherwise we'll package it as is (https://github.com/gentoo/gentoo/pull/16675). Thanks, David. [1] http://musl.libc.org/
David,
Here are 3 patches that we can apply on Gentoo linux in order to either compile with our musl profile[1] or comply with Gentoo QA. Two of these issues were discovered after your patch 15 and are not related to the previous issue with gcc-10.
I am not too inclined to turn the Make file into a Gentoo specific file. It (the Make file) is ugly, and I would change some things if needed, but it is really written for me (at this point in time). I ran across some changes when I was creating the one for my SDL port. I use the -g option for debugging information. I don't normally install the executable, but stripping the debug information before the install is reasonable.
It seems that the patch about ldflags was around since patch 09. I'm sorry for not telling about this one at the time.
We don't have any LDFLAGS, so why use it? Do we need the generality that it adds? One thing that may help is to use the -std=C99 option. I have that selected in the IDE I use for the SDL port.
Please let me know if you intend to do something about these. Otherwise we'll package it as is (https://github.com/gentoo/gentoo/pull/16675).
The addition of <fcntl.h> to unix.c doesn't seem to make any difference on my system. What is the benefit? In short, no current plans to update the source. Jonathan
Jonathan, On 20-08-01 13:24:23, Jonathan Osuch wrote:
We don't have any LDFLAGS, so why use it? Do we need the generality that it adds? It's just that it flags an annoying QA warning when compiling...
The addition of <fcntl.h> to unix.c doesn't seem to make any difference on my system. What is the benefit? O_RDONLY is defined in that header (https://pubs.opengroup.org/onlinepubs/009695399/basedefs/fcntl.h.html) which is included by sys/file.h via an #ifndef statement.
So, compiling fails when respecting strict POSIX rules like the musl library does. David.
David,
We don't have any LDFLAGS, so why use it? Do we need the generality that it adds?
It's just that it flags an annoying QA warning when compiling...
Hmm. I'll look into this. It doesn't hurt anything either.
The addition of <fcntl.h> to unix.c doesn't seem to make any difference on my system. What is the benefit?
O_RDONLY is defined in that header ( https://pubs.opengroup.org/onlinepubs/009695399/basedefs/fcntl.h.html ) which is included by sys/file.h via an #ifndef statement.
Okay. I'll work on it tomorrow. I am not keen on removing the -g option and the strip command, but I guess since no one is actually developing the code, it doesn't matter. Jonathan
Jonathan, On 20-08-01 17:59:36, Jonathan Osuch wrote:
The addition of <fcntl.h> to unix.c doesn't seem to make any difference on my system. What is the benefit?
O_RDONLY is defined in that header ( https://pubs.opengroup.org/onlinepubs/009695399/basedefs/fcntl.h.html ) which is included by sys/file.h via an #ifndef statement.
Okay. I'll work on it tomorrow. Thanks!
I overlooked one other issue that a Gentoo developer pointed out to me. The make install phase recompiles xfractint as follows make -j5 DESTDIR=/var/tmp/portage/x11-misc/xfractint-20.04_p15/image/usr install cd ./dos_help; ../hc /c; mv fractint.hlp .. HC - FRACTINT Help Compiler. Compiling: help.src Making hot-links. Paginating online help. Paginating document. Writing: helpdefs.h Note: FRACTINT must be re-compiled. Do you know what is causing this rebuild? Thanks in advance, David.
David,
I overlooked one other issue that a Gentoo developer pointed out to me. The make install phase recompiles xfractint as follows
make -j5 DESTDIR=/var/tmp/portage/x11-misc/xfractint- 20.04_p15/image/usr install cd ./dos_help; ../hc /c; mv fractint.hlp .. HC - FRACTINT Help Compiler.
Compiling: help.src Making hot-links. Paginating online help. Paginating document. Writing: helpdefs.h Note: FRACTINT must be re-compiled.
Do you know what is causing this rebuild?
I do now. This line in the Make file: install: xfractint fractint.hlp lists xfractint and fractint.hlp as prerequisites, so Make builds them first. I don't think there is any other way to ensure the executable is up to date before installing. You could check for the existance of the executable, but that is no guarantee of being up to date. Jonathan
David, Never mind to my last email. Patch 16 is uploaded. Jonathan
participants (2)
-
David Denoncin -
Jonathan Osuch