Rich, I've started trying to put inline assembly into Fractint for Windows. Now I need a magic decoder ring because you have changed every single variable name. If you had left it with just the g_ in front of everything, it would have been workable. Not so much now. NOT a happy camper. Jonathan
Life is change. The code base has been too cryptic for so long that other people are confused and afraid to modify it. Names that are full words are part of the change that is necessary to bring the code into a state where other people can contribute. Instead of inline assembly, what we need is a C++ equivalent so that it can be brought to other platforms. This code is moving forward, not back. -- "The Direct3D Graphics Pipeline" -- DirectX 9 draft available for download <http://www.xmission.com/~legalize/book/download/index.html> Legalize Adulthood! <http://blogs.xmission.com/legalize/>
On Thu, 2007-04-19 at 20:43 -0600, Richard wrote:
Life is change. The code base has been too cryptic for so long that other people are confused and afraid to modify it. Names that are full words are part of the change that is necessary to bring the code into a state where other people can contribute.
Unless I missed the translations, the changes from: kdbcount to g_input_counter and show_orbit to g_orbit_index are not intuitively obvious to me. But, I don't have the magic decoder ring. Change just to make things different is not necessarily a good thing.
Instead of inline assembly, what we need is a C++ equivalent so that it can be brought to other platforms.
Fine. I'll stop. Jonathan
In article <1177110096.3902.6.camel@linux.site>, Jonathan Osuch <osuchj@avalon.net> writes:
Unless I missed the translations, the changes from:
kdbcount to g_input_counter and
show_orbit to g_orbit_index
are not intuitively obvious to me.
Because you are not looking at how those variables are used and instead are fixated on the old names. show_orbit isn't being used like a flag, its being used as an index. etc. If the names and structure of the existing fractint code base were obvious to newcomers, then there wouldn't be a number of people who have attempted to understand the code and run away screaming into the night. That result has been expressed on this list several times. If you want a different result, then things have to change. If you just want to keep the code the same, then by all means continue to be the person who works on the DOS version. -- "The Direct3D Graphics Pipeline" -- DirectX 9 draft available for download <http://www.xmission.com/~legalize/book/download/index.html> Legalize Adulthood! <http://blogs.xmission.com/legalize/>
Don't like the names I chose? Suggest a better one. Familiarity with the existing names isn't a justification for the existing names. "showorbit" doesn't reflect how that variable was being used as it suggests a boolean flag. "kbdcount" is unnecessarily abbreviated and doesn't reflect how it was being used either. Equating all input with the keyboard is a DOS concept that is antiquated. In fact, the whole business of polling for input in the middle of compute loops, which is where this variable was being used, is also going away. Its time to evolve or die. Fractint hasn't evolved. Fractint is close to dying. Look at that huge list of contributors on the intro screen. How many of those people are contributing now? 2, besides me. How many new people have contributed since 1999, besides me? Few to none. Its time to evolve or die. Its time to embrace change. -- "The Direct3D Graphics Pipeline" -- DirectX 9 draft available for download <http://www.xmission.com/~legalize/book/download/index.html> Legalize Adulthood! <http://blogs.xmission.com/legalize/>
Also, since SVN has preserved all the changes, you can use it to examine changes. I don't seem to find something equivalent to cvs annotate, but the CVS repository is still available so you can use that if you have to. All the globals are still in externs.h. -- "The Direct3D Graphics Pipeline" -- DirectX 9 draft available for download <http://www.xmission.com/~legalize/book/download/index.html> Legalize Adulthood! <http://blogs.xmission.com/legalize/>
The equivalent of CVS annotate appears to be "SVN blame". -- "The Direct3D Graphics Pipeline" -- DirectX 9 draft available for download <http://www.xmission.com/~legalize/book/download/index.html> Legalize Adulthood! <http://blogs.xmission.com/legalize/>
participants (2)
-
Jonathan Osuch -
Richard